Skip to content

Fix ContentEncoding and ContentMediaType to Draft-06 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
+15 −5
Closed

Fix ContentEncoding and ContentMediaType to Draft-06 #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f269629
Initial plan
Copilot Feb 5, 2026
8e261de
Fix ContentEncoding and ContentMediaType to be Draft-06 features
Copilot Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/Enums/SchemaFeature.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,15 @@
*/
enum SchemaFeature: string
{
// Draft 06 features
case ContentMediaType = 'contentMediaType';
case ContentEncoding = 'contentEncoding';

// Draft 07 features
case If = 'if';
case Then = 'then';
case Else = 'else';
case IfThenElse = 'if-then-else';
case ContentMediaType = 'contentMediaType';
case ContentEncoding = 'contentEncoding';
case WriteOnly = 'writeOnly';
case ReadOnly = 'readOnly';
case Comment = '$comment';
Expand Down Expand Up @@ -67,13 +69,15 @@ enum SchemaFeature: string
public function getMinimumVersion(): SchemaVersion
{
return match ($this) {
// Draft 06 features
self::ContentMediaType,
self::ContentEncoding => SchemaVersion::Draft_06,

// Draft 07 features
self::If,
self::Then,
self::Else,
self::IfThenElse,
self::ContentMediaType,
self::ContentEncoding,
self::WriteOnly,
self::ReadOnly,
self::Comment,
Expand Down
8 changes: 7 additions & 1 deletion tests/Unit/VersionSupportTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,17 @@
expect($draft201909->supports(SchemaFeature::IfThenElse))->toBeTrue();
expect($draft202012->supports(SchemaFeature::IfThenElse))->toBeTrue();

expect($draft06->supports(SchemaFeature::ContentMediaType))->toBeFalse();
// Draft 06 features
expect($draft06->supports(SchemaFeature::ContentMediaType))->toBeTrue();
expect($draft07->supports(SchemaFeature::ContentMediaType))->toBeTrue();
expect($draft201909->supports(SchemaFeature::ContentMediaType))->toBeTrue();
expect($draft202012->supports(SchemaFeature::ContentMediaType))->toBeTrue();

expect($draft06->supports(SchemaFeature::ContentEncoding))->toBeTrue();
expect($draft07->supports(SchemaFeature::ContentEncoding))->toBeTrue();
expect($draft201909->supports(SchemaFeature::ContentEncoding))->toBeTrue();
expect($draft202012->supports(SchemaFeature::ContentEncoding))->toBeTrue();

expect($draft06->supports(SchemaFeature::Comment))->toBeFalse();
expect($draft07->supports(SchemaFeature::Comment))->toBeTrue();
expect($draft201909->supports(SchemaFeature::Comment))->toBeTrue();
Expand Down