Implemented Aquacomputer Next Vision coolant temperature reading#487
Open
420coupe wants to merge 1 commit intocorecoding:mainfrom
Open
Implemented Aquacomputer Next Vision coolant temperature reading#487420coupe wants to merge 1 commit intocorecoding:mainfrom
420coupe wants to merge 1 commit intocorecoding:mainfrom
Conversation
Owner
|
There are a lot of changes here, including removal of my donation link in the metadata.json. I think the biggest reason for the large diff is your IDE changed ' to ". Can you refactor this diff so it is easier to see the true changes? |
Author
|
@corecoding There we go, fixed difference in IDE prettier changes. Now you can see just the implementation of AC Next vision. |
420coupe
force-pushed
the
acvision
branch
2 times, most recently
from
d57efa2 to
e85577b
Compare
Author
|
Ok fixed the whitespace fixes from IDE as well, hence the forced pushes above. Now correctly displaying just the changes to implement acvision |
…ding as well as custom icons for the water temp and aio pump
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented Aquacomputer Next Vision coolant temperature reading - I was able to decode some of the response using an old visioncli repo as the starting base. There is still a lot of other things that can be decoded from response but 100% certain the current one I'm decoding matches the displayed value for coolant temp on the VISION OLED screen.
Additionally added custom icons for water temp and aio pump, custom icons appear both in the top bar and menu/sub-menu items. Also at first there was no fan speed being displayed until i
sudo modprobe nct6775and also added that command to/etc/modules-load.d/nct6775.confso it loads on restart.edited: added example of vitals with components below
