This repository was archived by the owner on Mar 18, 2019. It is now read-only.
Improved HTTP transport handling of query parameters#48
Open
ryanolf wants to merge 3 commits intocore-api:masterfrom
Open
Improved HTTP transport handling of query parameters#48ryanolf wants to merge 3 commits intocore-api:masterfrom
ryanolf wants to merge 3 commits intocore-api:masterfrom
Conversation
Author
|
I suppose this should more properly be titled "HTTP transport will respect query parameters in the url string." The use case I had in mind was via client.get(), since I think typically schemas aren't specifying query strings in their urls, and it's reasonable to expect that client.get() will not drop the querystring from the URL, which is the current behavior. |
Author
|
Now including fix for issue #36 by supplying a custom querystringify function to the URL parser. The function passed is based on the default but checks for array types and splits them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using coreapi to interact with an api that provides links in responses, that at times I would like to follow using the Client.get() method. These links include query parameters at times. A common example is listing paginated entries, wherein the page number for the "next" page may be a query parameter.
This pull request includes a minor change to the URL parser that allows it to combine query parameters that already exist in the url with those specified separately. This behavior is consistent with the python client.
I also included two tests: one with and one without query parameters specified outside the URL.