Open
Conversation
GetPsyched
requested changes
Jul 4, 2024
Author
But if they are functions on the database, then shouldn't they be in db module? |
Member
|
I guess you could do it that way too. I prefer putting it in |
GetPsyched
requested changes
Jul 5, 2024
GetPsyched
requested changes
Jul 6, 2024
src/db/mod.rs
Outdated
Comment on lines
+10
to
+11
| dotenv().ok(); | ||
| let database_url = env::var("DATABASE_URL").expect("DATABASE_URL must be set"); |
Member
There was a problem hiding this comment.
I've initialised a configuration module.
Suggested change
| dotenv().ok(); | |
| let database_url = env::var("DATABASE_URL").expect("DATABASE_URL must be set"); | |
| let database_url = get_configuration().connection_string(); |
And cleanup the remaining code (like removing dotenv from cargo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.