Enable adjusting memory policy from NRI plugins#166
Enable adjusting memory policy from NRI plugins#166askervin wants to merge 3 commits intocontainerd:mainfrom
Conversation
9374195 to
746b0ad
Compare
|
@askervin We have now the necessary plumbing in place and tagged in runtime Spec and our NRI deps here updated accordingly. So in principle we could go forward with this PR, but I think it needs a bit more work/additions before we can seriously consider it for merging:
|
|
@mikebrow @chrishenzie Could we give this a preliminary review, so if there is anything beside the ones already flagged we could try pointing them out and get them addressed in the same round ? |
c2ace9f to
38cddf5
Compare
38cddf5 to
ad3de7d
Compare
d440222 to
5363825
Compare
|
@mikebrow @chrishenzie Looks like all the review comments have been addressed. PTAL, could we get this approved ? |
mikebrow
left a comment
There was a problem hiding this comment.
The device injector plugin readme is getting a bit long.. WDYT about links from the top.. to each of these plugin supported adjustment types?
TODO... this and a few of the other plugins are getting useful enough that they should probably be mentioned/linked in the main readme.
Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
1f3b218 to
ec18ad4
Compare
@mikebrow Do you mean to add a link from each bullet list point at the top of
👍 Yes, and another TODO is that I promised @samuelkarp to roll a PR for renaming |
ec18ad4 to
ccdc672
Compare
Add support for adjusting container linux memory policy based on annotations. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
ccdc672 to
b979366
Compare
@mikebrow Assuming that's what you meant I went ahead and updated it accordingly. |
This PR implements
See set_mempolicy(2) for more details about Linux kernel memory policies.
This PR can be tested using
with something like this