Skip to content

supersonic nozzle#148

Draft
gregorychristian wants to merge 1 commit intoconservation-laws:developmentfrom
gregorychristian:development
Draft

supersonic nozzle#148
gregorychristian wants to merge 1 commit intoconservation-laws:developmentfrom
gregorychristian:development

Conversation

@gregorychristian
Copy link
Contributor

Simple 2d converging-diverging nozzle setup. All units are in cgs.

@tamiko tamiko self-requested a review July 4, 2024 18:38
@gregorychristian gregorychristian marked this pull request as draft August 11, 2024 15:18
@ejtovar
Copy link
Contributor

ejtovar commented Aug 16, 2024

Hi @gregorychristian, I apologize for the delayed response on this PR. To stay unified with the other files in prm/benchmarks/, would you mind modifying your input file to include some documentation and include a literature reference as well? You can take a look at prm/benchmarks/euler-mach3-cylinder-2d.prm for an example. Also, I don't think we need the .geo file in this PR? Thank you!

@tamiko
Copy link
Member

tamiko commented Aug 26, 2024

@ejtovar @gregorychristian I wouldn't mind to have the geo file floating around in the repository as well.

@gregorychristian
Copy link
Contributor Author

Hi @ejtovar @tamiko sorry for the late response, I'll add some documentation in the coming weeks and I also need to normalize/modify some of the units for (u, rho, p).

@tamiko
Copy link
Member

tamiko commented Aug 27, 2024

@gregorychristian While at it: For Euler it would be more natural to enforce slip boundary conditions (boundary id 2) instead of no-slip boundary conditions (boundary id 3). Would you mind to change that in the mesh?

@gregorychristian
Copy link
Contributor Author

@tamiko Sorry for the late reply, will do!

@tamiko
Copy link
Member

tamiko commented Sep 5, 2024

@gregorychristian No worries - we're all busy 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants