Skip to content
This repository was archived by the owner on Mar 12, 2024. It is now read-only.

Comments

Build static and shared Boost libraries#151

Open
mhadhbi wants to merge 3 commits intoconda-forge:1.72.xfrom
mhadhbi:build-static-and-shared-librairies
Open

Build static and shared Boost libraries#151
mhadhbi wants to merge 3 commits intoconda-forge:1.72.xfrom
mhadhbi:build-static-and-shared-librairies

Conversation

@mhadhbi
Copy link

@mhadhbi mhadhbi commented Oct 11, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@mhadhbi mhadhbi changed the base branch from main to 1.72.x October 11, 2023 10:02
Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason behind this PR to such an old version?

@jschueller
Copy link
Contributor

static libs are huge, at least move it to a sub-package

@h-vetinari
Copy link
Member

static libs are huge, at least move it to a sub-package

Definitely. A separate output libboost-static that depends on libboost-devel and targets main on the boost-feedstock

@mhadhbi
Copy link
Author

mhadhbi commented Oct 11, 2023

What's the reason behind this PR to such an old version?

Thanks for your review.
We are using this version in a legacy component and we cannot afford to migrate it to a newer version of Boost (this component is only running on Windows and we are porting it to Linux)

@mhadhbi
Copy link
Author

mhadhbi commented Oct 11, 2023

static libs are huge, at least move it to a sub-package

Definitely. A separate output libboost-static that depends on libboost-devel and targets main on the boost-feedstock

Thanks for your suggestion. I will try to do that.

@h-vetinari
Copy link
Member

Note that this feedstock will soon be archived. You should move on to 1.82+; it would still be very cool to have a PR that adds an output for static libraries (but in https://github.com/conda-forge/boost-feedstock).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants