Add latencies for 2xx responses#73
Open
chr1st1ank wants to merge 2 commits intocodesenberg:masterfrom
Open
Conversation
In cases where a service returns a lot of error codes it was impossible to know the response times of the successful operations. Now an additional histogram value collection for 2xx responses was added.
A condition was added so that the caption "Latency Distribution (2xx)" is no longer printed if there are no 2xx responses.
Author
|
Hey @codesenberg, |
acc7f4c to
9376ab4
Compare
Author
|
As a preliminary solution I used my forked master branch to publish this feature: https://github.com/chr1st1ank/bombardier/releases/tag/v1.3.5 No offense meant. I just needed windows + linux builds of it on multiple machines. I'd be very happy to merge it into the main repository and get rid of my fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cases where a service returns a lot of error codes it is impossible to know the response times of the successful operations. Now an additional histogram value collection for 2xx responses is added.
Before:
After:
In case of no 2xx the result is omitted:
The json output now looks like this:
{ "spec": { "numberOfConnections": 4, "testType": "timed", "testDurationSeconds": 2, "method": "GET", "url": "http://localhost:8088/calculate-limited?argument=abc", "body": "", "stream": false, "timeoutSeconds": 1, "client": "fasthttp" }, "result": { "bytesRead": 596028, "bytesWritten": 320988, "timeTakenSeconds": 3.512297515, "req1xx": 0, "req2xx": 3, "req3xx": 0, "req4xx": 0, "req5xx": 3482, "others": 0, "latency": { "mean": 2868.1977044476325, "stddev": 52273.760421009916, "max": 2505392, "percentiles": { "50": 1049, "75": 1169, "90": 1582, "95": 1907, "99": 2979 }, "percentiles2xx": { "50": 997482, "75": 997482, "90": 2505392, "95": 2505392, "99": 2505392 } }, "rps": { "mean": 1720.3570087831786, "stddev": 453.862925891273, "max": 2305.700383057032, "percentiles": { "50": 1773.912226, "75": 2167.367572, "90": 2259.393315, "95": 2276.839843, "99": 2289.22986 } } } }If there are no 2xx responses the new json attribute is empty:
"percentiles2xx": {}