Draft
Conversation
…n of large integers
Contributor
Author
|
VSCode May 2025 release (v1.101): |
Member
|
Nice, in this PR then, we should also bump the engine version in the package.json since this will only work in the newest versions of VS Code |
# Conflicts: # package-lock.json
Member
|
@janfh Is this PR ready for review? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #324
Alternative fix to avoid truncation. Requires node >= 21.
Update of Electron and Node can be tracked here:
https://redirect.github.com/microsoft/vscode/pull/245423
https://redirect.github.com/microsoft/vscode/issues/250125
Background:
JSON.parse will parse integers to Number (IEEE 754 64-bit float) and is limited to values less than what might be returned from the server. This will cause truncation of values less than -9007199254740991 and greater than 9007199254740991 (Number.MAX_SAFE_INTEGER).