Refactor toggle button #414
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return; | ||
| } | ||
|
|
||
| // No-op if already showing the desired fish set (matching or non-matching). |
Contributor
There was a problem hiding this comment.
My one thought is to combine this early return with the one above. And maybe this comment could be consolidated to "Pond fish are those that match (belong in the pond), whereas recall fish do not."
This reverts commit ab7ee32.
|
|
||
| trainer.train(); | ||
|
|
||
| const details = trainer.detailedExplanation(trainingOcean[0].fieldInfos); |
Contributor
There was a problem hiding this comment.
I know you already reverted this- I do think it would be worth deflaking in the future but I was always able to get a passing build (dorsalFins test passing included) with a rerun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #412 (comment).
To improve a11y on
fishlevels, the toggle button was refactored into two buttons so that it is now keyboard-navigable and screenreader compliant.Prior to this update, the toggle button switched back and forth between displaying matching and non-matching fish sets.
Because the button as been refactored into two buttons, we update so that if a user selects the Checkmark button, the matching fish set is displayed and if the user selects the Banned button, the non-matching fish set is displayed, even if the buttons are selected multiple times.
Before update
toggle-button-current.mov
After update
On level without info button:
after-toggle-button.mov
On level with info button:
after-with-info.mov