-
Notifications
You must be signed in to change notification settings - Fork 12
ml-activities release 0.1.1 #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
That's quite the jump! |
hahahah I didn't tag anyone yet because I checked the history and am rerunning it. When i checked the version locally it must've given me the npm version |
@wilkie just waiting for it to finish and I'll update |
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@code-dot-org/ml-activities", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: could update version number in the README at https://github.com/code-dot-org/ml-activities/blob/main/README.md#publishing-a-new-version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I can update that with more explicit instructions about how to determine what to bump it to instead. I'll draft something! I think "With 0.0.29 replaced by the new version number that should be published." implies that we shouldn't have to keep that line of the readme updated each time.
This includes a11y updates, primarily for screenreader compatibility and keyboard interactions
Phew! Was able to publish 0.1.1 on npm officially: https://www.npmjs.com/package/@code-dot-org/ml-activities/v/0.1.1
Jira: https://codedotorg.atlassian.net/browse/SL-1551