Refactor templates to have fewer imported values#37
Draft
cat5inthecradle wants to merge 20 commits intomainfrom
Draft
Refactor templates to have fewer imported values#37cat5inthecradle wants to merge 20 commits intomainfrom
cat5inthecradle wants to merge 20 commits intomainfrom
Conversation
cat5inthecradle
commented
Jan 12, 2024
| - codepipeline.amazonaws.com | ||
| Version: '2012-10-17' | ||
| Path: /service-role/ | ||
| PermissionsBoundary: !ImportValue IAM-DevPermissions |
Contributor
Author
There was a problem hiding this comment.
This is a tentative removal. I don't think we need it here. This stack is being deployed by an Admin anyway. I might be overlooking something though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
!ImportValue adds cross-stack dependencies and breaks the cleaner top-down passing of parameters. This PR eliminates !ImportValue from the application stack via two changes:
This also modifies the deploy scripts to create a change set which can be reviewed before applying.
Notes for reviewers - the shell script changes are independent of the template changes, but having them in place will make reviewing the template changes easier.
TESTING
Follow Up