Merged
Conversation
snewcomer
commented
Dec 26, 2017
app/models/conversation.js
Outdated
| message: belongsTo('message', { async: true }), | ||
| user: belongsTo('user', { async: true }) | ||
| user: belongsTo('user', { async: true }), | ||
| project: belongsTo('project', { async: true }) |
Contributor
Author
There was a problem hiding this comment.
@joshsmith since a project already exists on the message, I wasn't sure if there was another way to pass up the project_id to the backend than this.
Contributor
There was a problem hiding this comment.
I would just make sure to alpha order here.
Contributor
There was a problem hiding this comment.
I would just make sure to alpha order here.
joshsmith
reviewed
Dec 27, 2017
| testForAttributes('conversation', ['insertedAt', 'readAt', 'status', 'updatedAt']); | ||
| testForBelongsTo('conversation', 'message'); | ||
| testForBelongsTo('conversation', 'user'); | ||
| testForBelongsTo('conversation', 'project'); |
snewcomer
force-pushed
the
add-project-to-conversation
branch
2 times, most recently
from
9623ef4 to
00f09d9
Compare
joshsmith
approved these changes
Dec 27, 2017
snewcomer
force-pushed
the
add-project-to-conversation
branch
from
00f09d9 to
8932425
Compare
Contributor
Author
|
@joshsmith I think this PR is g2g... |
Contributor
|
It is, save a rebase, which is why I approved and marked as |
Contributor
|
Wait, we don't have |
snewcomer
force-pushed
the
add-project-to-conversation
branch
from
8932425 to
c654c15
Compare
Contributor
Author
|
Nope. I thought this was the precursor to this PR I believe - code-corps/code-corps-api#1343 |
joshsmith
force-pushed
the
add-project-to-conversation
branch
from
c654c15 to
7571e57
Compare
snewcomer
force-pushed
the
add-project-to-conversation
branch
from
7571e57 to
c654c15
Compare
snewcomer
force-pushed
the
add-project-to-conversation
branch
from
c654c15 to
3de4f7b
Compare
snewcomer
force-pushed
the
add-project-to-conversation
branch
from
3de4f7b to
fab6da0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will send up the project_id to the API in order to help with the below issue on the api side.
References
code-corps/code-corps-api#1313