Allow fields to include labelled hyperlinks and be split into sections#851
Open
milanlakhani wants to merge 3 commits intocncf:masterfrom
Open
Allow fields to include labelled hyperlinks and be split into sections#851milanlakhani wants to merge 3 commits intocncf:masterfrom
milanlakhani wants to merge 3 commits intocncf:masterfrom
Conversation
Signed-off-by: Milan Lakhani <mlakhani14@bloomberg.net>
When there is a 'sections' field in settings.yml, that 'sections' object must contain all the keys that are in every item's 'extra' section in landscape.yml. It need not contain keys that are not in the 'extra' section. Signed-off-by: Milan Lakhani <mlakhani14@bloomberg.net>
To add a labelled hyperlink in one of your landscape yaml fields, use <label>(hyperlink) , so same as markdown syntax except <> instead of [] . Signed-off-by: Milan Lakhani <mlakhani14@bloomberg.net>
✅ Deploy Preview for landscapeapp ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
Author
|
Hi @AndreyKozlov1984 , I'm back from my holiday now, hope you are well. Feel free to let me know any improvements that I can make if it would help :) |
Contributor
|
@milanlakhani That is too much change, and it requires serious changes in the format. Ideally the format should be same as before, let me think a bit what we can afford |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enhances the look of fields in the item dialog boxes in two ways - enabling labelled hyperlinks and adding sections.
The labelled hyperlinks change allows
extrafields inlandscape.ymlto have text values that link to a url that is not the same as the text. To add a labelled hyperlink, the syntax to use is<label>(hyperlink)(so same as markdown syntax except <> instead of [] )The sections change adds an optional config in
settings.yml, which can put the 'extra' fields in an item's dialog box into sections to improve the appearance.Needless to
This is what the item detail box looks like with and without sections:

Without:
With:

The placement of the optional
sectionsconfig insettings.ymlis as follows:CC @michaelmoss @awright @GeriG966 @danielsilverstone-ct @Abhi0469