addExternalInfo: Correctly reuse cached crunchbase info#836
Open
danielsilverstone-ct wants to merge 1 commit intocncf:masterfrom
Open
addExternalInfo: Correctly reuse cached crunchbase info#836danielsilverstone-ct wants to merge 1 commit intocncf:masterfrom
danielsilverstone-ct wants to merge 1 commit intocncf:masterfrom
Conversation
When a crunchbase key is not in the environment; but the settings request crunchbase data, we should reuse the data from the processed landscape file. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
✅ Deploy Preview for landscapeapp ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
|
This works for me. |
milanlakhani
approved these changes
Jul 25, 2022
Contributor
|
global.skip_crunchbase |
Author
This breaks landscapes which are designed to consume crunchbase data (such as the CNCF one) - it is clearly a bug that the cached crunchbase data was not being used as evidenced by the message: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a crunchbase key is not in the environment; but the settings
request crunchbase data, we should reuse the data from the processed
landscape file.
This fixes #835