fix(pilota-build): incorrect merge function signature for cycled-enum#360
Open
fix(pilota-build): incorrect merge function signature for cycled-enum#360
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
==========================================
+ Coverage 66.37% 66.59% +0.22%
==========================================
Files 88 88
Lines 24577 24710 +133
==========================================
+ Hits 16312 16456 +144
+ Misses 8265 8254 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@cursor run |
Author
known issue, already fix in another pr. let me cherry-pick to this pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Motivation
Fix the compile error of the pb generated code caused by nested enum.
For nested enum, pilota-build will use
::std::option::Optionand::std::boxed::Boxto wrap the real enum type in struct field declaration. But themergemethod of the enum type only accept::std::option::Option<Self>.Solution
Change the type of the first param of the nested-enum
mergemethod from&mut Option<Self>to&mut Option<Box<T>>.