Add 'client_credentials' OAuth2 authentication flow#17
Add 'client_credentials' OAuth2 authentication flow#17Amit-CloudSufi wants to merge 1 commit intodevelopfrom
Conversation
|
Please Fix conflicts |
|
Please revert unintended formatting ! |
|
Resolve conflict |
Amit-CloudSufi
force-pushed
the
httpOath
branch
2 times, most recently
from
4e22508 to
5c95376
Compare
src/main/java/io/cdap/plugin/http/common/http/OAuthGrantType.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/http/common/http/OAuthClientAuthentication.java
Outdated
Show resolved
Hide resolved
Amit-CloudSufi
force-pushed
the
httpOath
branch
from
70e21f5 to
e8348e8
Compare
Amit-CloudSufi
force-pushed
the
httpOath
branch
from
817649c to
e506fc1
Compare
| } | ||
| } | ||
|
|
||
| public void validate(FailureCollector failureCollector) { |
There was a problem hiding this comment.
these changes are not removed, yet it is showing in diff, let the sequence of methods remain same to avoid unnecessary confusion.
There was a problem hiding this comment.
Sequence is same as before, it;s just that previous indentation was wrong I.e. 4 spaces, and currently the check style which was recommended by Ankit has 2 spaces, because of that it got updated when made changes. That's why it is shown is removed and added which updated spaces.
| * Enum encoding the handled Oauth2 Grant Types | ||
| */ | ||
| public enum OAuthGrantType implements EnumWithValue { | ||
| REFRESH_TOKEN("refresh token", "Refresh Token"), |
There was a problem hiding this comment.
Is the name refresh token intended and not missing a _ ?
There was a problem hiding this comment.
I think it;s fine, @vikasrathee-cs let me know if we need to update it
psainics
left a comment
psainics
left a comment
There was a problem hiding this comment.
Some file have 2 space of indentation and some have 4.
eg:
OAuthClientAuthentication (2 space)
OAuthGrantType (4 space)
Please keep formatting consistent in the PR
| protected String authType; | ||
|
|
||
| @Name(PROPERTY_OAUTH2_ENABLED) | ||
| @Name(PROPERTY_OAUTH2_ENABLED) |
There was a problem hiding this comment.
Revert unintended changes
| @Nullable | ||
| public String getAuthUrl() { | ||
| return authUrl; | ||
| return authUrl; |
There was a problem hiding this comment.
Revert unintended changes
Amit-CloudSufi
force-pushed
the
httpOath
branch
from
8b97950 to
30e78c9
Compare
Amit-CloudSufi
force-pushed
the
httpOath
branch
from
ddb9e10 to
c490a5e
Compare
|
raised a separate pr with indentation fix : #18 |
3 participants
No description provided.