Conversation
Enable GitHub merge queue on main branch by adding merge_group triggers to test.yml, pre-commit.yml, and codeql.yml. Updates lint-golangci conditional to run for both pull_request and merge_group events. Fixes base SHA reference in pre-commit to use merge_group.base_sha fallback. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR adds Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2195 +/- ##
=======================================
Coverage 77.29% 77.30%
=======================================
Files 960 960
Lines 91088 91088
=======================================
+ Hits 70410 70415 +5
+ Misses 16593 16589 -4
+ Partials 4085 4084 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
what
merge_groupevent trigger totest.yml,pre-commit.yml, andcodeql.ymlworkflowslint-golangcijob to run for bothpull_requestandmerge_groupeventspre-commit.ymlto usemerge_group.base_shaas fallback whenpull_request.base.shais unavailablewhy
GitHub merge queues require workflows to explicitly listen for the
merge_groupevent. Without these triggers, required checks never fire when a PR enters the queue, causing the merge queue to timeout after 1 hour. This follows the established pattern from Cloud Posse's terraform-components repositories.references
Aligns with Cloud Posse merge queue implementation in
cloudposse-terraform-components/aws-accountand other component repos. Enables merge queue feature for safer, batched merges on the main branch.Summary by CodeRabbit