This repository was archived by the owner on Apr 2, 2019. It is now read-only.
Add default cell: "string" option for a column#524
Open
gabriellupu wants to merge 1 commit intocloudflarearchive:masterfrom
gabriellupu:default-string-cell
Open
Add default cell: "string" option for a column#524gabriellupu wants to merge 1 commit intocloudflarearchive:masterfrom gabriellupu:default-string-cell
gabriellupu wants to merge 1 commit intocloudflarearchive:masterfrom
gabriellupu:default-string-cell
Conversation
Author
|
@wyuenho what do you think about this change ? |
Contributor
|
I think I need more data to default to a column type. I'm not convinced that "string" is the most commonly used type, hence I'm just going to leave this PR open for feedback from other people. |
Author
|
Ok, this sounds like a good plan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since "string" is the most common cell type used, I see useful having it set as a default option instead of undefined - that will throw an error if not specified, of course.