Added headers to ClearbitError in order to pass back relevant data to caller#34
Open
pdspicer wants to merge 1 commit intoclearbit:masterfrom
Open
Added headers to ClearbitError in order to pass back relevant data to caller#34pdspicer wants to merge 1 commit intoclearbit:masterfrom
pdspicer wants to merge 1 commit intoclearbit:masterfrom
Conversation
…from certain error responses, i.e. the "Retry-After" header returned from rate_limit errors
|
@maccman any update on this PR? It would tidy up my code a bit with not a huge change 👍 |
Contributor
|
Will make sure we review this today 👍 |
Contributor
|
We talked about it internally and think this definitely makes sense as a quality of life improvement! It'd be great if we could add a spec to make sure they're being passed through in a consistent manner. Would you mind adding one @pdspicer and I can then go ahead and merge? |
Contributor
|
Hey @pdspicer just a bump — if you could add specs that'd be wonderful! If not, I'll circle round and add some when I have time 👍 Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful when encountering a rate-limit error. If headers are passed back, retry-after can be used to delay for the appropriate amount of time before attempting a follow-up call.