Open
Conversation
nvmusoke
requested review from
bkonuwa,
dkordik,
lihnick,
pixelbandito and
wendigolabs
pixelbandito
approved these changes
Sep 3, 2021
Contributor
pixelbandito
left a comment
pixelbandito
left a comment
There was a problem hiding this comment.
A couple of nice-to-have comments.
Also, I don't see tests, but I'm ok with that being a follow-on.
| <h1>Input.Radio</h1> | ||
| <Input | ||
| onChange={(e) => | ||
| console.log(e.target.checked) || |
Contributor
There was a problem hiding this comment.
This isn't gonna hurt anything, but you don't need to leave a console log in here. If I did it for checkbox, it was a mistake.
Contributor
Author
There was a problem hiding this comment.
going to remove this from checkbox as well
| putting IDs on input elements, but they are. | ||
| */} | ||
| {/* eslint-disable-next-line jsx-a11y/label-has-associated-control */} | ||
| <label className="text-xl inline-block mb-2"> |
Contributor
There was a problem hiding this comment.
You might be able to remove the eslint-disable by adding htmlFor="SampleRadio", since you're not using the InteractiveInput wrapper anymore.
dkordik
approved these changes
Sep 20, 2021
bkonuwa
approved these changes
Sep 20, 2021
delc82
approved these changes
Sep 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds radio to the list of Rover UI Inputs
I also removed the onChange prop in Interactive Input to make it more flexible and so it can properly report synthetic events in the Actions tab.