EVER-14024 : Form : Implemented form/input HTML5 ValidityState valida…#321
EVER-14024 : Form : Implemented form/input HTML5 ValidityState valida…#321wendigolabs wants to merge 6 commits intocision:masterfrom
Conversation
…tion, integrated with custom validation.
|
I re-forked this since the changes are pretty big and we probably want to start the commentary over. |
| </Form> | ||
| ); | ||
|
|
||
| describe('<Form />', () => { |
There was a problem hiding this comment.
Need something like it('handles native events', ....
| 'tooShort', | ||
| 'typeMismatch', | ||
| 'valueMissing', | ||
| ]; |
|
Much of the discussion, and advise by @pixelbandito in mikemfleming:FORM-292 is still relevant and needs to be addressed after we've gone over the larger issues related to the |
src/components/Form/README.md
Outdated
| @@ -0,0 +1,3 @@ | |||
| # \<Form\> | |||
|
|
|||
| Add your documentation for the `Form` component here. | |||
There was a problem hiding this comment.
Flesh ValidityState out, then get busy.
|
Finally got around to reading the validity state docs, looks good! |
|
This is looking really good. I know there's some stuff left to do, at least around documentation, but if you want to rebase on master / merge master in, and push this so we can all play with it, I'm ok with that. |
2 participants
…tion, integrated with custom validation.
Working draft, needs better tests, examples, PR summary.