Record externs in the functions map so that --callee can find them.#7
Open
esky-software wants to merge 1 commit intochaudron:masterfrom
Open
Record externs in the functions map so that --callee can find them.#7esky-software wants to merge 1 commit intochaudron:masterfrom
esky-software wants to merge 1 commit intochaudron:masterfrom
Conversation
chaudron
reviewed
Dec 7, 2023
cally.py
Outdated
| print_buf(std_buf, '"{}" -> "{}";'.format(func, caller)) | ||
|
|
||
| if caller not in functions: | ||
| if (caller not in functions) or (len(functions[caller]["files"]) == 0): |
Owner
There was a problem hiding this comment.
Dont think you need the extra () sets.
Owner
|
I have not looked at the logic of the patch, but there are some style issues to fix, and it needs a DCO. |
esky-software
force-pushed
the
master
branch
2 times, most recently
from
2944a33 to
0e0b1c5
Compare
Owner
|
Thanks for the changes, can you force-push this as a single commit? I'll try to do a proper review over the weekend. |
Signed-off-by: Jeremy Davies <jeremy@davies.name>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows --callee to refer to extern functions.