Skip to content

Add annotations support to ScaledObject template #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tasuku43 merged 2 commits into from
Mar 11, 2026
+7 −3
Merged

Add annotations support to ScaledObject template #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec27e62
Add annotations support to ScaledObject template
tasuku43 Mar 11, 2026
5ebf345
Bump http-service chart version to 0.2.0
tasuku43 Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion http-service/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ apiVersion: v2
name: http-service
description: An opinionated Helm chart for language-agnostic HTTP services with sensible defaults
type: application
version: 0.1.0
version: 0.2.0
8 changes: 6 additions & 2 deletions http-service/templates/scaled-object.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
{{- if eq .Values.autoscaling.type "keda" }}
{{- $keda := required "autoscaling.keda is required when type is keda" .Values.autoscaling.keda }}
{{- $triggers := required "autoscaling.keda.triggers is required when type is keda" $keda.triggers }}
apiVersion: keda.sh/v1alpha1
kind: ScaledObject
metadata:
name: {{ include "http-service.fullname" . }}
namespace: {{ .Release.Namespace }}
labels:
{{- include "http-service.labels" . | nindent 4 }}
{{- with $keda.annotations }}
annotations:
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
scaleTargetRef:
{{- if .Values.rollout.enabled }}
Expand All @@ -16,8 +22,6 @@ spec:
kind: Deployment
{{- end }}
name: {{ include "http-service.fullname" . }}
{{- $keda := required "autoscaling.keda is required when type is keda" .Values.autoscaling.keda }}
{{- $triggers := required "autoscaling.keda.triggers is required when type is keda" $keda.triggers }}
minReplicaCount: {{ required "autoscaling.minReplicas is required" .Values.autoscaling.minReplicas }}
maxReplicaCount: {{ required "autoscaling.maxReplicas is required" .Values.autoscaling.maxReplicas }}
{{- with $keda.pollingInterval }}
Expand Down