fix(help): add styled whitespace with configurable background#685
Open
rrrodzilla wants to merge 4 commits intocharmbracelet:masterfrom
Open
fix(help): add styled whitespace with configurable background#685rrrodzilla wants to merge 4 commits intocharmbracelet:masterfrom
rrrodzilla wants to merge 4 commits intocharmbracelet:masterfrom
Conversation
Added WhitespaceStyle fields to both short and full help Styles struct, llowing customization of whitespace appearance between keys and descriptions. Previously whitespace was unstyled, now it matches the aesthetic of other elements and can be customized (e.g. with background colors for testing). - Added ShortWhitespace and FullWhitespace to Styles struct - Modified ShortHelpView to use styled whitespace between key and desc - Modified FullHelpView to use styled whitespace between key and desc - Added tests to verify whitespace styling behavior Fixes charmbracelet#571
|
Looks like this whitespace between the truncated keys and the ellipsis remains unstyled. Line 228 in a2a300a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added WhitespaceStyle fields to both short and full help Styles struct, llowing customization of whitespace appearance between keys and descriptions. Previously whitespace was unstyled, now it matches the aesthetic of other elements and can be customized (e.g. with background colors for testing).
Fixes #571