Conversation
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #764 +/- ##
=======================================
Coverage 69.61% 69.61%
=======================================
Files 150 150
Lines 7075 7075
Branches 1144 1153 +9
=======================================
Hits 4925 4925
+ Misses 2085 2051 -34
- Partials 65 99 +34
🚀 New features to boost your workflow:
|
|
Packages with OIDC enabled: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3529577720
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| id-token: write | ||
| repository-projects: write | ||
| uses: celo-org/reusable-workflows/.github/workflows/npm-publish.yaml@develop | ||
| uses: celo-org/reusable-workflows/.github/workflows/npm-publish.yaml@develop-npm-publishing-oidc |
There was a problem hiding this comment.
Pin reusable workflow to a stable ref
Switching the release job to @develop-npm-publishing-oidc makes production releases depend on a feature branch in another repository; if that branch is renamed, deleted, or force-pushed, pushes to master/hotfixes will fail to start the publish workflow and block package releases. Please reference an immutable tag or commit SHA instead of this temporary branch name.
Useful? React with 👍 / 👎.
Use
develop-npm-publishing-oidcfor NPM packages.PR is draft, will set as ready for review when this is configured in NPM registry for all packages
PR-Codex overview
This PR updates the GitHub Actions workflow configuration for releasing by modifying the
usesdirective to point to a different version of thenpm-publish.yamlfile, which likely includes changes related to OIDC (OpenID Connect) for token management.Detailed summary
usesfromcelo-org/reusable-workflows/.github/workflows/npm-publish.yaml@developto
celo-org/reusable-workflows/.github/workflows/npm-publish.yaml@develop-npm-publishing-oidcid-token: writeandrepository-projects: writepermissionsnode-version: 20andversion-command: yarn version-then-update-filessettings