Skip to content

sessions: must provide cookie factory to sessions manager #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shoenig merged 1 commit into from
Feb 10, 2026
Merged

sessions: must provide cookie factory to sessions manager #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions middles/oauth/sessions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,12 @@ type Sessions struct {
CookieFactory *CookieFactory
}

func NewSessions(cache Cache[*conceal.Text, Identity]) *Sessions {
// NewSessions creates a new Sessions for managing sessions and cookies
// associated with those sessions.
func NewSessions(cookies *CookieFactory, cache Cache[*conceal.Text, Identity]) *Sessions {
return &Sessions{
Cache: cache,
Cache: cache,
CookieFactory: cookies,
}
}

Expand Down
18 changes: 8 additions & 10 deletions middles/oauth/sessions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,12 @@ func TestSessions_Create(t *testing.T) {

cache := &mockCache{storage: make(map[string]Identity)}

// initialize the cookie factory
sessions := &Sessions{
Cache: cache,
CookieFactory: &CookieFactory{
Name: "session-token",
Secure: true,
Clock: testNow,
},
}
// initialize the sessions manager with the cache and a cookie factory
sessions := NewSessions(&CookieFactory{
Name: "session-token",
Secure: true,
Clock: testNow,
}, cache)

id := Identity(12345)
ttl := 1 * time.Hour
Expand Down Expand Up @@ -66,8 +63,9 @@ func TestSessions_Create(t *testing.T) {
func TestSessions_Match(t *testing.T) {
t.Parallel()

cookies := (*CookieFactory)(nil)
cache := &mockCache{storage: make(map[string]Identity)}
sessions := NewSessions(cache)
sessions := NewSessions(cookies, cache)

id := Identity(12345)
token := conceal.UUIDv4()
Expand Down