Fix for using only component router#74
Open
gleb-sevruk wants to merge 2 commits intocastillo-io:masterfrom
Open
Fix for using only component router#74gleb-sevruk wants to merge 2 commits intocastillo-io:masterfrom
gleb-sevruk wants to merge 2 commits intocastillo-io:masterfrom
Conversation
alexcastillo
requested changes
Mar 25, 2017
| "repository": { | ||
| "type": "git", | ||
| "url": "git://github.com/castillo-io/angular-css" | ||
| "url": "git://github.com/Excelion/angular-css" |
Member
There was a problem hiding this comment.
I think this should remain untouched.
| "name": "angular-css", | ||
| "main": "./angular-css.js", | ||
| "version": "1.0.8", | ||
| "version": "1.0.9", |
Member
There was a problem hiding this comment.
Can you not bum the version? That way I can plan better what goes into what version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was null reference exception when using only component router, i added simple nullref check.