Optimize espresso-dev-node startup#281
Closed
tuler wants to merge 6 commits intoprerelease/v2-alphafrom
Closed
Conversation
🦋 Changeset detectedLatest commit: 5da851a The changes in this PR will be included in the next version bump. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Coverage Report for ./apps/cli
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
Member
Author
|
CI will keep failing while cannon package is not published to registry |
6a60701 to
0ddb6c9
Compare
6601b6a to
ff69f85
Compare
Member
Author
|
My latest test showed this error (and a lot more after that). |
207efd6 to
9c42c33
Compare
9c42c33 to
5da851a
Compare
Member
Author
|
Integrated into draft PR at #304 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to speed up espresso-dev-node startup time by using a new option called
ESPRESSO_DEV_NODE_L1_DEPLOYMENT=skiponly currently available at themainunreleased version ofespresso-dev-node. It expects the smart contract to already be deployed to the L1 provider (anvil).For that to work we first created a cannon package for the espresso network smart contracts.
That is available at https://github.com/cartesi/espresso-network/tree/cartesi
So the first step to test this PR is to clone that repo, switch to branch
cartesiand runcannon build(assuming cannon is installed).Then we integrated the cannon package into our devnet, which can be built using
That assumes the cannon package
espresso-network:0.0.1@mainwas built locally.ps: when a stable version exists, we can publish to cannon registry.
Then we changed the binary used by the SDK to a
mainunreleased version.Copy the unreleased devnet into SDK and build it.
Then run the CLI with a
develimage: