audit: WCAG, SEO, responsiveness, and optimization pass#138
Open
carsonSgit wants to merge 1 commit intomainfrom
Open
audit: WCAG, SEO, responsiveness, and optimization pass#138carsonSgit wants to merge 1 commit intomainfrom
carsonSgit wants to merge 1 commit intomainfrom
Conversation
WCAG: - Add canvas to JSX with aria-hidden (was never rendered; grid highlight effect now works) - GuideModal: add role=dialog, aria-modal, aria-labelledby, focus trap, focus close button on open - Add .sr-only utility class to globals.scss - AsciiFooter: add sr-only "Thanks for stopping by!" for screen readers - BracketLink: inject sr-only "(opens in new tab)" when target=_blank - ExperienceList/EducationList: sr-only text on company links - All sections (Intro/Projects/Experience/Education): add aria-labelledby + ids on headings - Increase --text-muted from #71717a → #8a8a94 (WCAG AA 4.5:1 contrast on dark bg) - Remove !important from p/li color rule so detail-panel colors apply correctly - section-list__trigger: add :focus-visible outline - guide-trigger: split hover/focus, add :focus-visible outline - guide-modal__close: add :focus-visible outline SEO: - Canonical URL via metadata.alternates - Richer page title and description mentioning Carson's role and schools - Add authors and keywords metadata fields - JSON-LD Person schema (name, jobTitle, sameAs, alumniOf, knowsAbout) - Move <Script> inside <body> (valid HTML structure) - Add <link rel="preconnect"> for cloud.umami.is - Create public/sitemap.xml - Update robots.txt with Sitemap directive Responsiveness: - Portfolio max-width: 1600px (prevents extreme stretching on ultrawide) - New 1200px breakpoint: gap reduced from 12rem → 5rem (prevents cramped mid-range columns) - ASCII art: smaller font on ≤600px, hidden on ≤400px to prevent horizontal overflow Optimization: - Avatar image: explicit width=56 height=56 to prevent CLS - Intro subtitle already had fetchpriority via Avatar component https://claude.ai/code/session_01TnCck6GrSfEZeUWY7jDwfj
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WCAG:
SEO:
Responsiveness:
Optimization:
https://claude.ai/code/session_01TnCck6GrSfEZeUWY7jDwfj