feat: Add a method to Arm64InsnDetail to expose the post_index flag#197
Open
PandasAreBears wants to merge 3 commits intocapstone-rust:masterfrom
Open
feat: Add a method to Arm64InsnDetail to expose the post_index flag#197PandasAreBears wants to merge 3 commits intocapstone-rust:masterfrom
PandasAreBears wants to merge 3 commits intocapstone-rust:masterfrom
Conversation
jiegec
approved these changes
Feb 28, 2026
tmfink
requested changes
Mar 2, 2026
Member
tmfink
left a comment
There was a problem hiding this comment.
I like the change, but could you add the same change to capstone-rs/src/arch/arm.rs?
It would also be great if you could add a unit test for the new methods.
Author
|
I've added a test which asserts the correctness of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
post_indexflag was added tocs_arm64in this commit: f8ae229This change exposes the value of the flag in
Arm64InsnDetail.Thanks