Skip to content

feat: Add a method to Arm64InsnDetail to expose the post_index flag#197

Open
PandasAreBears wants to merge 3 commits intocapstone-rust:masterfrom
PandasAreBears:feat/arm64-post-index-flag
Open

feat: Add a method to Arm64InsnDetail to expose the post_index flag#197
PandasAreBears wants to merge 3 commits intocapstone-rust:masterfrom
PandasAreBears:feat/arm64-post-index-flag

Conversation

@PandasAreBears
Copy link

The post_index flag was added to cs_arm64 in this commit: f8ae229

This change exposes the value of the flag in Arm64InsnDetail.

Thanks

@jiegec jiegec requested a review from tmfink February 28, 2026 15:49
Copy link
Member

@tmfink tmfink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change, but could you add the same change to capstone-rs/src/arch/arm.rs?
It would also be great if you could add a unit test for the new methods.

@PandasAreBears
Copy link
Author

I've added a test which asserts the correctness of the writeback and post_index fields. It wasn't clear how to cleanly slot it into the existing test_arch_mode_endian_insns pattern. There probably a nicer way of writing this test but I don't have any more time today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants