Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Spelling Mistakes
- java/cap_in_non_cap_applications.md:138:26 Unknown word "alesi"
Generally, for each spelling mistake there are 2 ways to fix it:
- Fix the spelling mistake and commit it.
- The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.
Co-authored-by: René Jeglinsky <rene.jeglinsky@sap.com>
There was a problem hiding this comment.
Spelling Mistakes
- java/cap_in_non_cap_applications.md:170:135 Unknown word "applicaton"
Generally, for each spelling mistake there are 2 ways to fix it:
- Fix the spelling mistake and commit it.
- The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.
There was a problem hiding this comment.
Spelling Mistakes
- java/cap_in_non_cap_applications.md:185:378 Unknown word "applicaton"
Generally, for each spelling mistake there are 2 ways to fix it:
- Fix the spelling mistake and commit it.
- The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.
java/cap_in_non_cap_applications.md
Outdated
|
|
||
| Credentials and service coordinates for connecting to a SAP Event Hub instance need to be provided by the runtime environment of your application. For more details you can have a look at the the [SAP Event Hub CAP Plugin](https://github.com/cap-java/cds-feature-event-hub). | ||
|
|
||
| ## Use the Transactional Outbox to add Resilience to Audit Log and Messaging |
There was a problem hiding this comment.
Outbox requires CDS model -> requires cds build -> workaround is required in none-CAP app. Better omit for now.
There was a problem hiding this comment.
@BraunMatthias As far as I understood it only the persistent outbox requires a CDS model. Thus, I would remove the sections about the persistency (and resilience) and just explain that with the automatically added in-memory outbox the service call is linked to the transaction outcome.
|
|
||
| <dependency> | ||
| <groupId>com.sap.cds</groupId> | ||
| <artifactId>cds-framework-spring-boot</artifactId> |
There was a problem hiding this comment.
why is the spring boot dependency required for audit log API?
There was a problem hiding this comment.
I guess cds-services-impl as runtime dependency is mandatory.
There was a problem hiding this comment.
As far as I understand you need to have cds-framework-spring-boot as a runtime depdendency in order to have the Spring Boot integration of the runtime. If I leave this out the CAP Java runtime is not initialised on startup. Alternatively, we can take cds-starter-spring-boot. Both of them have cds-runtime-impl as a transitive dependency. Sadly, cds-framework-spring-boot has cds-runtime-impl as a compile-time dependency.
There was a problem hiding this comment.
Spelling Mistakes
- java/cap_in_non_cap_applications.md:17:168 Unknown word "depdendencies"
- java/cap_in_non_cap_applications.md:180:378 Unknown word "applicaton"
Generally, for each spelling mistake there are 2 ways to fix it:
- Fix the spelling mistake and commit it.
- The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.
removed the part about the persistent outbox. this currently needs some manual workarounds that we won't document.
Co-authored-by: BraunMatthias <59841349+BraunMatthias@users.noreply.github.com>
3 participants
No description provided.