feat: improve yarn pnp compatibility#176
Open
leegeunhyeok wants to merge 1 commit intocallstackincubator:mainfrom
Open
feat: improve yarn pnp compatibility#176leegeunhyeok wants to merge 1 commit intocallstackincubator:mainfrom
leegeunhyeok wants to merge 1 commit intocallstackincubator:mainfrom
Conversation
|
@leegeunhyeok is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves Rozenite integration to support Yarn PnP environments.
The current auto-discovery implementation for installed plugins assumes a
node_moduleslinker environment and does not work in Yarn PnP setups. In PnP environments, plugins need to be discovered from the PnP virtual paths of installed dependencies.Solution
This PR modifies the plugin discovery logic to handle Yarn PnP environments. When running in a PnP environment, the implementation now searches for plugins in the PnP virtual paths of installed dependencies.
Other logic, such as patching the devtools-frontend path, already works correctly in PnP environments. This is because Yarn PnP patches the
fsmodule to resolve virtual paths automatically.Compatibility
This change has no impact on non-PnP environments. The existing behavior remains unchanged for traditional
node_modulessetups.Related Issue
Context
Discussion: #174
Discord: https://discord.com/channels/426714625279524876/1397852261736255528/1468831055808172055
Testing
A test environment is available in the following repository. Please refer to the README for verification and testing instructions:
https://github.com/leegeunhyeok/rozenite-pnp
pnpm build:all pnpm --filter @rozenite/middleware pack --out package.tgz # Copy the generated `package.tgz` to the root of `rozenite-pnp`Unit tests
pnpm --filter @rozenite/middleware test