Set CMake policy version lower bound to 3.5#365
Open
penguinpee wants to merge 1 commit intobuggins:masterfrom
Open
Set CMake policy version lower bound to 3.5#365penguinpee wants to merge 1 commit intobuggins:masterfrom
penguinpee wants to merge 1 commit intobuggins:masterfrom
Conversation
Also specify upper bound as 4.0. With CMake 4.0 policies before 3.5 will be dropped. CMake 4.0 also requires the upper bound to be specified.
Author
|
Fedora is planning to upgrade CMake to 4.0. I tested the Linux build with CMake 4.0 as well as CMake 3.30.8 and didn't notice any regression. I did not test the Android build nor any of the third party libraries (we do not use them). I just assumed they would be compatible. More info: https://cmake.org/cmake/help/latest/release/4.0.html |
13 tasks
|
thanks for figuring this out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also specify upper bound as 4.0.
With CMake 4.0 policies before 3.5 will be dropped. CMake 4.0 also
requires the upper bound to be specified.