[filter-effects-1] Add filter()#271
Open
yisibl wants to merge 1 commit intobrowserscore:pre-splitfrom
Open
Conversation
SebastianZ
requested changes
Apr 11, 2025
Collaborator
There was a problem hiding this comment.
The syntax for the filter() function is:
filter() = filter( [ <image> | <string> ], <filter-value-list> )So three annotations:
- The first parameter can also be a
<string>. Though that's a bit strange, because the spec. doesn't define what this value refers to. I'll try to dig deeper and may create a spec. issue for that. - The second parameter is a
<filter-value-list>. That means we should have at least one test for multiple filters. <image>includes more than just gradients and URLs. So maybe we should add a few tests regarding those other values.
| }, | ||
| tests: [ | ||
| // filter() = filter( [ <image> | <string> ], <filter-value-list> ) | ||
| 'filter(conic-gradient(red), invert(1))', |
Collaborator
There was a problem hiding this comment.
Single-stop gradients were only added recently, as far as I know. So I wouldn't include those in the tests for filter().
Generally, I don't think it is necessary to test (so many) different gradient syntaxes here. One basic test per gradient function or even just one for gradients in general should be fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, only Safari supports it: https://caniuse.com/css-filter-function