put QR code in Songbook #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove extra whitespace padding on qr-code.png too
Owner
Author
|
@chrisglein Does this layout for putting the QR code on the ToC look alright? I also centered the version info under the QR code, look funny otherwise. |
brewingcode
force-pushed
the
put-qr-code-in-songbook
branch
from
94226fb to
5aac0a3
Compare
brewingcode
force-pushed
the
put-qr-code-in-songbook
branch
from
4226f6d to
2e4a6ff
Compare
Owner
Author
|
Whoops, somehow "The Dreadnaughts 2019" leaked into the ToC header, I have fixed that so now it is just "Joli Rogue" again: 
|
Owner
Author
|
Reduced the QR code size just a touch, looks a bit better: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove extra whitespace padding on qr-code.png too: https://www.nayuki.io/page/qr-code-generator-library