Parse -codecs output from 1.x-4.x builds of FFmpeg#195
Open
svjson wants to merge 1 commit intobramp:masterfrom
Open
Parse -codecs output from 1.x-4.x builds of FFmpeg#195svjson wants to merge 1 commit intobramp:masterfrom
svjson wants to merge 1 commit intobramp:masterfrom
Conversation
Owner
|
Sorry for the long delay. This change looks great, thanks for writing it, and sorry I never reviewed it. It looks like I accepted 9a5507c which just fixed it by moving to the latest format. But this pull request looks better by trying the old and new. If you are willing I'll accept this if you can resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The output format of the flags column of codecs have changed starting with FFMpeg 1.0, and so ffmpeg.codecs() returns an empty list.
This pull request uses a different regex pattern for parsing the -codecs output of ffmpeg depending on -version.