chore: extend pr template with note on karpenter k8s settings#86
Open
ginglis13 wants to merge 1 commit intobottlerocket-os:developfrom
Open
chore: extend pr template with note on karpenter k8s settings#86ginglis13 wants to merge 1 commit intobottlerocket-os:developfrom
ginglis13 wants to merge 1 commit intobottlerocket-os:developfrom
Conversation
Signed-off-by: Gavin Inglis <giinglis@amazon.com>
ginglis13
force-pushed
the
pr-template-karp-settings
branch
from
90dda78 to
18b8502
Compare
ginglis13
changed the title
Contributor
|
Karpenter is extending the usage of I believe we can drop this once they merge their change upstream - aws/karpenter-provider-aws#8254 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add a note in PR template about extending Karpenter's settings model whenever Bottlerocket adds new settings under
settings.kubernetes. Karpenter models Bottlerocket Kubernetes settings in their project here and any new setting is added tosettings.kubernetesmust also be added to the Karpenter model in order for users to be able to configure the setting via Karpenter userData.This PR template is the same as the bottlerocket-os org's template (https://github.com/bottlerocket-os/.github/blob/master/PULL_REQUEST_TEMPLATE) with checklist added to prompt PR authors to open a PR to github.com/aws/karpenter-provider-aws per-emptively with the setting.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.