Add k8s settings: prefer-closest-numa-nodes and max-allowable-numa-nodes#848
Open
piyush-jena wants to merge 3 commits intobottlerocket-os:developfrom
Open
Add k8s settings: prefer-closest-numa-nodes and max-allowable-numa-nodes#848piyush-jena wants to merge 3 commits intobottlerocket-os:developfrom
piyush-jena wants to merge 3 commits intobottlerocket-os:developfrom
Conversation
Update settings-models dependency to pick up the new topology-manager-policy-options setting type.
Add topologyManagerPolicyOptions rendering to kubelet-config templates, version-gated by GA status verified from Kubernetes source code: - prefer-closest-numa-nodes (bool): GA in k8s 1.32+ (added to 1.32-1.35) - max-allowable-numa-nodes (int, >= 8): GA in k8s 1.35 (added to 1.35 only) Source: pkg/kubelet/cm/topologymanager/policy_options.go stableOptions set
95690d3 to
aaebef5
Compare
Signed-off-by: Piyush Jena <jepiyush@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes # bottlerocket-os/bottlerocket#4750
Description of changes:
Add 2 topology manager policy options:
max-allowable-numa-nodes- GA k8s-1.35+prefer-closest-numa-nodes- GA k8s-1.32+Testing done:
Enabled the following settings and rebooted the instance:
Then ran a pod with the following spec:
Its important that requests and limits are equal for both CPU and memory to ensure it is in the
GuaranteedQoS class for the CPU pinning as a result of thestaticpolicy to work properly.The assigned CPUs for this pod was 1,2,65,66.
The NUMA node ranges for this instances are:
node0: 0-31, 64-95
node1: 32-63, 96-127
All 4 CPUs belong to NUMA node0. The
prefer-closest-numa-nodespolicy worked as expected.For
max-allowable-numa-nodesI show the limits enforced by kubernetes are also applied here.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.