Merged
Conversation
lcreid
force-pushed
the
533-namespaced-id-for
branch
from
018669f to
ad306ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
namespaceoption on theform_for, or in our case,bootstrap_form_forwas reported in #533 as not working. I made some test cases, and the labels had the namespace added, except for Rails 7.2 (which at the time of my investigation is the earliest version we're testing/supporting).It turns out that this was a Rails bug. Rails fixed this in https://github.com/rails/rails/pull/55719.
It was surprisingly hard to add the namespace myself. Since Rails 7.2 is already in security support only, I chose to leave it as a Rails bug and skip the tests for Rails 7.2.
Closes: #533 .