aria-describedby for Errors#782
Merged
lcreid merged 9 commits intobootstrap-ruby:mainfrom Dec 9, 2025
Merged
Conversation
lcreid
force-pushed
the
743-aria-describedby-for-errors
branch
from
6461e52 to
bec939c
Compare
lcreid
force-pushed
the
743-aria-describedby-for-errors
branch
from
08207c8 to
6bfc697
Compare
lcreid
commented
Dec 5, 2025
| assert_equivalent_html expected, output | ||
| end | ||
|
|
||
| test 'upgrade doc for form_group renders the "error" class and message correctly when object is invalid' do |
Contributor
Author
There was a problem hiding this comment.
This was a test for the update document for Bootstrap 3 to Bootstrap 4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
idto errors, andaria-describedbyto inputs, when the field has errors, as suggested:https://www.w3.org/WAI/tutorials/forms/notifications/#:~:text=providing%20instructions.-,After%20submit,success%20input%20%7B%20border%3A%203px%20solid%20%23007a00%3B%20%7D,-During%20typing
Closes: #743