Remove unsafe from encoder using extend pattern#13
Merged
Conversation
Replace raw pointer manipulation with safe Vec::with_capacity + extend + flatten pattern. This removes 2 unsafe blocks while maintaining equivalent performance (within noise margin for large inputs, ~40% faster for mostly-ASCII inputs). The key insight is that extend() can use the iterator's size hint to avoid per-element capacity checks when capacity is pre-allocated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
encoder.rswith safeVec::with_capacity+extend+flattenpatternBenchmark Results
The
mostly_asciipath is ~40% faster due to better iterator optimization.Approach
The key insight is that
extend()uses the iterator's size hint to avoid per-element capacity checks when capacity is pre-allocated.Test plan