feat(intl): implement Temporal.PlainYearMonth.prototype.toLocaleString#5098
Draft
alienx5499 wants to merge 3 commits intoboa-dev:mainfrom
Draft
feat(intl): implement Temporal.PlainYearMonth.prototype.toLocaleString#5098alienx5499 wants to merge 3 commits intoboa-dev:mainfrom
alienx5499 wants to merge 3 commits intoboa-dev:mainfrom
Conversation
…ng, and toLocaleTimeString
…void JS alloc in Date toLocaleString path
Test262 conformance changes
Fixed tests (7):Tested main commit: |
This was referenced Mar 15, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5098 +/- ##
===========================================
+ Coverage 47.24% 59.21% +11.97%
===========================================
Files 476 563 +87
Lines 46892 62749 +15857
===========================================
+ Hits 22154 37159 +15005
- Misses 24738 25590 +852 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #5083.
It changes the following:
Temporal.PlainYearMonth.prototype.toLocaleStringper spec, using the sharedformat_date_time_localepipeline (same pattern asDate.prototype.toLocaleDateString).timestamp_for_first_of_month_utcindate/utils.rsto produce a formatting anchor (first day of month at 00:00:00 UTC) forIntl.DateTimeFormat; no extra JS object allocation on the hot path.mod testsand tests for PlainYearMonth.toLocaleString: returns string, invalid receiver throws TypeError, and (withintlfeature) different locales and options affect output.Testing
cargo test -p boa_engine --no-default-features --features temporal --lib plain_year_month(Temporal-only tests)cargo test -p boa_engine --features intl_bundled,temporal --lib plain_year_month(with intl)