Implement core disposal logic for explicit resource management#5079
Open
abhinavs1920 wants to merge 5 commits intoboa-dev:mainfrom
Open
Implement core disposal logic for explicit resource management#5079abhinavs1920 wants to merge 5 commits intoboa-dev:mainfrom
abhinavs1920 wants to merge 5 commits intoboa-dev:mainfrom
Conversation
Signed-off-by: Abhinav Sharma <abhinavs1920bpl@gmail.com>
Test262 conformance changes
Tested main commit: |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5079 +/- ##
===========================================
+ Coverage 47.24% 59.11% +11.86%
===========================================
Files 476 567 +91
Lines 46892 62783 +15891
===========================================
+ Hits 22154 37113 +14959
- Misses 24738 25670 +932 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Abhinav Sharma <abhinavs1920bpl@gmail.com>
Signed-off-by: Abhinav Sharma <abhinavs1920bpl@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #4445 .
Make
usingactually dispose ( continued work )Follow-up to my last PR (#4649) that added parsing.
Now when a block ends, resources get cleaned up properly.
usingand cleans up at end of blocksWorks like: