Skip to content

Optimize array unshift#5076

Open
yush-1018 wants to merge 8 commits intoboa-dev:mainfrom
yush-1018:optimize-array-unshift
Open

Optimize array unshift#5076
yush-1018 wants to merge 8 commits intoboa-dev:mainfrom
yush-1018:optimize-array-unshift

Conversation

@yush-1018
Copy link
Contributor

Add dense array fast-path for Array.prototype.unshift, same as the existing one in [shift]

Partially addresses #3407.

…test262 permissions

- Add new pr_management.yml workflow to auto-add/remove 'waiting-for-review' label
- Auto-assign reviewers and milestone on new PRs
- Add pull-requests: write permission to test262_pr.yml for external PR comments

Closes boa-dev#3977
- Remove extra permissions setting from test262_pr
- Remove hardcoded default assignees since github handles it automatically
@yush-1018 yush-1018 requested a review from a team as a code owner March 14, 2026 21:00
@github-actions github-actions bot added this to the v1.0.0 milestone Mar 14, 2026
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 52,963 52,963 0
Passed 49,935 49,933 -2
Ignored 2,207 2,207 0
Failed 821 823 +2
Panics 0 0 0
Conformance 94.28% 94.28% -0.00%
Broken tests (2):
test/built-ins/Array/prototype/unshift/set-length-array-length-is-non-writable.js (previously Passed)
test/built-ins/Array/prototype/unshift/set-length-array-is-frozen.js (previously Passed)

Tested main commit: 1dacd48b3356a377ba9d594d9a9ce898b519f7a6
Tested PR commit: dfc891be658ae3c5c4739c275a4d5bd07b4c08c5
Compare commits: 1dacd48...dfc891b

@codecov
Copy link

codecov bot commented Mar 14, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.04%. Comparing base (6ddc2b4) to head (dfc891b).
⚠️ Report is 854 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/builtins/array/mod.rs 50.00% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5076       +/-   ##
===========================================
+ Coverage   47.24%   59.04%   +11.80%     
===========================================
  Files         476      563       +87     
  Lines       46892    62602    +15710     
===========================================
+ Hits        22154    36964    +14810     
- Misses      24738    25638      +900     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jedel1043 jedel1043 added Waiting On Review Waiting on reviews from the maintainers and removed waiting-for-review labels Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting On Review Waiting on reviews from the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants