fix(runtime-limits): charge built-in iteration loops against loop budget#5070
Closed
linisha15 wants to merge 3 commits intoboa-dev:mainfrom
Closed
fix(runtime-limits): charge built-in iteration loops against loop budget#5070linisha15 wants to merge 3 commits intoboa-dev:mainfrom
linisha15 wants to merge 3 commits intoboa-dev:mainfrom
Conversation
Contributor
Author
|
Hi! @jedel1043 , please review my pr . |
Test262 conformance changes
Tested main commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5070 +/- ##
===========================================
+ Coverage 47.24% 59.13% +11.88%
===========================================
Files 476 563 +87
Lines 46892 62589 +15697
===========================================
+ Hits 22154 37011 +14857
- Misses 24738 25578 +840 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Since the issue has already been resolved in another PR, I'll close this one. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
This PR ensures built-in iteration performed in Rust respects the runtime loop budget configured via
set_loop_iteration_limit.What changed
IncrementLoopIteration::operation((), context).String.prototype.repeatand shared Array/TypedArray iteration helper paths.Why
Previously, loop limits applied to VM-compiled loops but not all built-in Rust loops, which could bypass runtime protection.
Validation
-Verified runtime-limit tests for:
Closes #5060