Skip to content

Remove aws-lc-rs in favour of ring#5068

Merged
nekevss merged 1 commit intoboa-dev:mainfrom
jedel1043:remove-aws-lc-rs
Mar 15, 2026
Merged

Remove aws-lc-rs in favour of ring#5068
nekevss merged 1 commit intoboa-dev:mainfrom
jedel1043:remove-aws-lc-rs

Conversation

@jedel1043
Copy link
Member

Using aws-lc-rs causes miscompilations in MacOS. Even then we're not using ring in boa_runtime, so folks can provide their preferred crypto library.

@jedel1043 jedel1043 added this to the v1.0.0 milestone Mar 14, 2026
@jedel1043 jedel1043 requested a review from a team as a code owner March 14, 2026 18:49
@jedel1043 jedel1043 added C-Dependencies Pull requests that update a dependency file A-Internal Changes that don't modify execution behaviour labels Mar 14, 2026
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 52,963 52,963 0
Passed 49,935 49,935 0
Ignored 2,207 2,207 0
Failed 821 821 0
Panics 0 0 0
Conformance 94.28% 94.28% 0.00%

Tested main commit: 1f1cf0301b8a43a5893d535444279b7b11e5b3ce
Tested PR commit: 95a5d1e613031bff3ce02ac4934dd4b0c3b25111
Compare commits: 1f1cf03...95a5d1e

@codecov
Copy link

codecov bot commented Mar 14, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.09%. Comparing base (6ddc2b4) to head (95a5d1e).
⚠️ Report is 857 commits behind head on main.

Files with missing lines Patch % Lines
cli/src/main.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5068       +/-   ##
===========================================
+ Coverage   47.24%   59.09%   +11.84%     
===========================================
  Files         476      563       +87     
  Lines       46892    62571    +15679     
===========================================
+ Hits        22154    36974    +14820     
- Misses      24738    25597      +859     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jedel1043 jedel1043 added the Waiting On Review Waiting on reviews from the maintainers label Mar 15, 2026
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me!

@nekevss nekevss added this pull request to the merge queue Mar 15, 2026
Merged via the queue into boa-dev:main with commit 965f38c Mar 15, 2026
19 checks passed
@github-actions github-actions bot removed the Waiting On Review Waiting on reviews from the maintainers label Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Internal Changes that don't modify execution behaviour C-Dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants