Skip to content

fix(bench): enable intl_bundled feature for boa_engine#5067

Merged
jedel1043 merged 1 commit intoboa-dev:mainfrom
Lokesh0224:fix-bench-intl-feature
Mar 14, 2026
Merged

fix(bench): enable intl_bundled feature for boa_engine#5067
jedel1043 merged 1 commit intoboa-dev:mainfrom
Lokesh0224:fix-bench-intl-feature

Conversation

@Lokesh0224
Copy link
Contributor

After #4898, running cargo bench -p boa_benches without --features boa_engine/intl_bundled panics with "Intl is not defined" since the Intl benchmark scripts require the intl feature to be enabled.
This adds intl_bundled as a default feature for boa_benches so cargo bench -p boa_benches works without any panics message: "Intl is not defined".

@Lokesh0224 Lokesh0224 requested a review from a team as a code owner March 14, 2026 18:29
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 52,963 52,963 0
Passed 49,935 49,935 0
Ignored 2,207 2,207 0
Failed 821 821 0
Panics 0 0 0
Conformance 94.28% 94.28% 0.00%

Tested main commit: 1f1cf0301b8a43a5893d535444279b7b11e5b3ce
Tested PR commit: 1be97f6282b2fbdf2f6bb437fe96b437f4385bb8
Compare commits: 1f1cf03...1be97f6

@codecov
Copy link

codecov bot commented Mar 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.09%. Comparing base (6ddc2b4) to head (1be97f6).
⚠️ Report is 849 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5067       +/-   ##
===========================================
+ Coverage   47.24%   59.09%   +11.84%     
===========================================
  Files         476      563       +87     
  Lines       46892    62569    +15677     
===========================================
+ Hits        22154    36974    +14820     
- Misses      24738    25595      +857     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jedel1043 jedel1043 added this pull request to the merge queue Mar 14, 2026
Merged via the queue into boa-dev:main with commit 7e06bf4 Mar 14, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants