fix(bench): enable intl_bundled feature for boa_engine#5067
Merged
jedel1043 merged 1 commit intoboa-dev:mainfrom Mar 14, 2026
Merged
fix(bench): enable intl_bundled feature for boa_engine#5067jedel1043 merged 1 commit intoboa-dev:mainfrom
jedel1043 merged 1 commit intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Tested main commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5067 +/- ##
===========================================
+ Coverage 47.24% 59.09% +11.84%
===========================================
Files 476 563 +87
Lines 46892 62569 +15677
===========================================
+ Hits 22154 36974 +14820
- Misses 24738 25595 +857 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #4898, running cargo bench -p boa_benches without --features boa_engine/intl_bundled panics with "Intl is not defined" since the Intl benchmark scripts require the intl feature to be enabled.
This adds intl_bundled as a default feature for boa_benches so
cargo bench -p boa_benchesworks without any panics message: "Intl is not defined".