feat(fetch): Support ArrayBuffer and TypedArray request body in Fetch RequestInit

.github/workflows/nightly_build.yml

@@ -30,7 +30,7 @@ jobs:
         uses: actions/checkout@v6
 
       - name: Install Rust toolchain
-        uses: dtolnay/rust-toolchain@stable
+        uses: dtolnay/rust-toolchain@master
         with:
           toolchain: stable
           targets: ${{ matrix.target }}

.github/workflows/pull_request.yml

@@ -23,7 +23,7 @@ jobs:
           fetch-depth: 0
 
       - name: Install Rust toolchain
-        uses: dtolnay/rust-toolchain@stable
+        uses: dtolnay/rust-toolchain@master
         with:
           toolchain: stable
 

.github/workflows/release.yml

@@ -22,7 +22,7 @@ jobs:
         uses: actions/checkout@v6
 
       - name: Install Rust toolchain
-        uses: dtolnay/rust-toolchain@stable
+        uses: dtolnay/rust-toolchain@master
         with:
           toolchain: stable
 
@@ -52,7 +52,7 @@ jobs:
         uses: actions/checkout@v6
 
       - name: Install Rust toolchain
-        uses: dtolnay/rust-toolchain@stable
+        uses: dtolnay/rust-toolchain@master
         with:
           toolchain: stable
           targets: wasm32-unknown-unknown
@@ -112,7 +112,7 @@ jobs:
         uses: actions/checkout@v6
 
       - name: Install Rust toolchain
-        uses: dtolnay/rust-toolchain@stable
+        uses: dtolnay/rust-toolchain@master
         with:
           toolchain: stable
           targets: ${{ matrix.target }}

.github/workflows/rust.yml

@@ -37,7 +37,9 @@ jobs:
         uses: actions/checkout@v6
 
       - name: Install Rust toolchain
-        uses: dtolnay/rust-toolchain@stable
+        uses: dtolnay/rust-toolchain@master
+        with:
+          toolchain: stable
 
       - name: Cache cargo
         uses: actions/cache@v5
@@ -82,7 +84,7 @@ jobs:
         uses: actions/checkout@v6
 
       - name: Install Rust toolchain
-        uses: dtolnay/rust-toolchain@stable
+        uses: dtolnay/rust-toolchain@master
         with:
           toolchain: stable
 
@@ -128,8 +130,9 @@ jobs:
         uses: actions/checkout@v6
 
       - name: Install Rust nightly with miri
-        uses: dtolnay/rust-toolchain@nightly
+        uses: dtolnay/rust-toolchain@master
         with:
+          toolchain: nightly
           components: miri
 
       - name: Cache cargo
@@ -165,7 +168,7 @@ jobs:
         run: echo "rust_version=$(grep '^rust-version' Cargo.toml | cut -d' ' -f3 | tr -d '"')" >> $GITHUB_OUTPUT
 
       - name: Install Rust toolchain
-        uses: dtolnay/rust-toolchain@stable
+        uses: dtolnay/rust-toolchain@master
         with:
           toolchain: ${{ steps.rust_version.outputs.rust_version }}
 
@@ -185,7 +188,7 @@ jobs:
         uses: actions/checkout@v6
 
       - name: Install Rust toolchain
-        uses: dtolnay/rust-toolchain@stable
+        uses: dtolnay/rust-toolchain@master
         with:
           toolchain: stable
           components: rustfmt
@@ -217,7 +220,7 @@ jobs:
         uses: actions/checkout@v6
 
       - name: Install Rust toolchain
-        uses: dtolnay/rust-toolchain@stable
+        uses: dtolnay/rust-toolchain@master
         with:
           toolchain: stable
           components: clippy
@@ -260,7 +263,7 @@ jobs:
         uses: actions/checkout@v6
 
       - name: Install Rust toolchain
-        uses: dtolnay/rust-toolchain@stable
+        uses: dtolnay/rust-toolchain@master
         with:
           toolchain: stable
 
@@ -289,7 +292,7 @@ jobs:
         uses: actions/checkout@v6
 
       - name: Install Rust toolchain
-        uses: dtolnay/rust-toolchain@stable
+        uses: dtolnay/rust-toolchain@master
         with:
           toolchain: stable
 
@@ -321,7 +324,7 @@ jobs:
         uses: actions/checkout@v6
 
       - name: Install Rust toolchain
-        uses: dtolnay/rust-toolchain@stable
+        uses: dtolnay/rust-toolchain@master
         with:
           toolchain: stable
 

.github/workflows/test262_pr.yml

@@ -30,7 +30,7 @@ jobs:
           ref: ${{ github.event.pull_request.head.sha }}
 
       - name: Install Rust toolchain
-        uses: dtolnay/rust-toolchain@stable
+        uses: dtolnay/rust-toolchain@master
         with:
           toolchain: stable
 

.github/workflows/test262_release.yml

@@ -26,7 +26,7 @@ jobs:
 
       # Install Rust toolchain
       - name: Install Rust toolchain
-        uses: dtolnay/rust-toolchain@stable
+        uses: dtolnay/rust-toolchain@master
         with:
           toolchain: stable
 

.github/workflows/webassembly.yml

@@ -45,7 +45,7 @@ jobs:
         uses: actions/checkout@v6
 
       - name: Install Rust toolchain
-        uses: dtolnay/rust-toolchain@stable
+        uses: dtolnay/rust-toolchain@master
         with:
           toolchain: stable
 

core/engine/src/module/loader/mod.rs

@@ -62,7 +62,10 @@ pub fn resolve_module_specifier(
 
     // On Windows, also replace `/` with `\`. JavaScript imports use `/` as path separator.
     #[cfg(target_family = "windows")]
-    let specifier = specifier.replace('/', "\\");
+    let specifier = {
+        use cow_utils::CowUtils;
+        specifier.cow_replace('/', "\\").into_owned()
+    };
 
     let short_path = Path::new(&specifier);
 

core/runtime/src/fetch/mod.rs

@@ -146,7 +146,7 @@ async fn fetch_inner<T: Fetcher>(
     };
 
     let mut request = if let Some(options) = options {
-        options.into_request_builder(Some(request))?
+        options.into_request_builder(Some(request), &mut context.borrow_mut())?
     } else {
         request
     };

core/runtime/src/fetch/request.rs

@@ -4,6 +4,7 @@
 //!
 //! [mdn]: https://developer.mozilla.org/en-US/docs/Web/API/Request
 use super::HttpRequest;
+use boa_engine::object::builtins::{JsArrayBuffer, JsDataView, JsSharedArrayBuffer, JsTypedArray};
 use boa_engine::value::{Convert, TryFromJs};
 use boa_engine::{
     Finalize, JsData, JsObject, JsResult, JsString, JsValue, Trace, boa_class, js_error,
@@ -67,9 +68,11 @@ impl RequestInit {
     ///
     /// # Errors
     /// If the body is not a valid type, an error is returned.
+    #[allow(clippy::too_many_lines)]
     pub fn into_request_builder(
         mut self,
         request: Option<HttpRequest<Vec<u8>>>,
+        context: &mut boa_engine::Context,
     ) -> JsResult<HttpRequest<Vec<u8>>> {
         let mut builder = HttpRequest::builder();
         let mut request_body = Vec::new();
@@ -104,12 +107,86 @@ impl RequestInit {
         }
 
         if let Some(body) = &self.body {
-            // TODO: add more support types.
-            if let Some(body) = body.as_string() {
-                let body = body.to_std_string().map_err(
+            // TODO: support additional Fetch body types (e.g., Blob, FormData, URLSearchParams).
+            if let Some(str_body) = body.as_string() {
+                let body_str = str_body.to_std_string().map_err(
                     |_| js_error!(TypeError: "Request constructor: body is not a valid string"),
                 )?;
-                request_body = body.into_bytes();
+                request_body = body_str.into_bytes();
+            } else if let Some(object) = body.as_object() {
+                if let Ok(buf) = JsArrayBuffer::from_object(object.clone()) {
+                    if let Some(bytes) = buf.to_vec() {
+                        request_body = bytes;
+                    } else {
+                        return Err(
+                            js_error!(TypeError: "Request constructor: ArrayBuffer detached or unusable"),
+                        );
+                    }
+                } else if let Ok(buf) = JsSharedArrayBuffer::from_object(object.clone()) {
+                    request_body = buf.to_vec();
+                } else if let Ok(ta) = JsTypedArray::from_object(object.clone()) {
+                    let buffer = ta.buffer(context)?;
+                    let buffer_obj = buffer
+                        .as_object()
+                        .ok_or_else(|| {
+                            js_error!(TypeError: "Request constructor: TypedArray buffer must be an object")
+                        })?
+                        .clone();
+
+                    let offset = ta.byte_offset(context)?;
+                    let length = ta.byte_length(context)?;
+
+                    if let Ok(array_buffer) = JsArrayBuffer::from_object(buffer_obj.clone()) {
+                        if let Some(buffer_data) = array_buffer.data() {
+                            let bytes = buffer_data.as_ref();
+                            request_body = bytes[offset..offset + length].to_vec();
+                        } else {
+                            return Err(
+                                js_error!(TypeError: "Request constructor: TypedArray buffer detached or unusable"),
+                            );
+                        }
+                    } else if let Ok(shared_buffer) = JsSharedArrayBuffer::from_object(buffer_obj) {
+                        let bytes = shared_buffer.to_vec();
+                        request_body = bytes[offset..offset + length].to_vec();
+                    } else {
+                        return Err(
+                            js_error!(TypeError: "Request constructor: TypedArray buffer is not an ArrayBuffer or SharedArrayBuffer"),
+                        );
+                    }
+                } else if let Ok(dv) = JsDataView::from_object(object.clone()) {
+                    let buffer = dv.buffer(context)?;
+                    let buffer_obj = buffer
+                        .as_object()
+                        .ok_or_else(|| {
+                            js_error!(TypeError: "Request constructor: DataView buffer must be an object")
+                        })?
+                        .clone();
+
+                    let offset = usize::try_from(dv.byte_offset(context)?).unwrap_or(0);
+                    let length = usize::try_from(dv.byte_length(context)?).unwrap_or(0);
+
+                    if let Ok(array_buffer) = JsArrayBuffer::from_object(buffer_obj.clone()) {
+                        if let Some(buffer_data) = array_buffer.data() {
+                            let bytes = buffer_data.as_ref();
+                            request_body = bytes[offset..offset + length].to_vec();
+                        } else {
+                            return Err(
+                                js_error!(TypeError: "Request constructor: DataView buffer detached or unusable"),
+                            );
+                        }
+                    } else if let Ok(shared_buffer) = JsSharedArrayBuffer::from_object(buffer_obj) {
+                        let bytes = shared_buffer.to_vec();
+                        request_body = bytes[offset..offset + length].to_vec();
+                    } else {
+                        return Err(
+                            js_error!(TypeError: "Request constructor: DataView buffer is not an ArrayBuffer or SharedArrayBuffer"),
+                        );
+                    }
+                } else {
+                    return Err(
+                        js_error!(TypeError: "Request constructor: body is not a supported type"),
+                    );
+                }
             } else {
                 return Err(
                     js_error!(TypeError: "Request constructor: body is not a supported type"),
@@ -158,6 +235,7 @@ impl JsRequest {
     pub fn create_from_js(
         input: Either<JsString, JsRequest>,
         options: Option<RequestInit>,
+        context: &mut boa_engine::Context,
     ) -> JsResult<Self> {
         let request = match input {
             Either::Left(uri) => {
@@ -175,7 +253,7 @@ impl JsRequest {
         };
 
         if let Some(options) = options {
-            let inner = options.into_request_builder(Some(request))?;
+            let inner = options.into_request_builder(Some(request), context)?;
             Ok(Self { inner })
         } else {
             Ok(Self { inner: request })
@@ -199,6 +277,7 @@ impl JsRequest {
     pub fn constructor(
         input: Either<JsString, JsObject>,
         options: Option<RequestInit>,
+        context: &mut boa_engine::Context,
     ) -> JsResult<Self> {
         // Need to use a match as `Either::map_right` does not have an equivalent
         // `Either::map_right_ok`.
@@ -212,6 +291,6 @@ impl JsRequest {
             }
             Either::Left(i) => Either::Left(i),
         };
-        JsRequest::create_from_js(input, options)
+        JsRequest::create_from_js(input, options, context)
     }
 }