feat(fetch): implement bodyUsed and clone() for Request and Response (#4992)#5041
Closed
RajdeepKushwaha5 wants to merge 3 commits intoboa-dev:mainfrom
Closed
feat(fetch): implement bodyUsed and clone() for Request and Response (#4992)#5041RajdeepKushwaha5 wants to merge 3 commits intoboa-dev:mainfrom
RajdeepKushwaha5 wants to merge 3 commits intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Tested main commit: |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5041 +/- ##
===========================================
+ Coverage 47.24% 59.10% +11.86%
===========================================
Files 476 563 +87
Lines 46892 62580 +15688
===========================================
+ Hits 22154 36988 +14834
- Misses 24738 25592 +854 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
This pull request implements the
.clone()method and the.bodyUsedproperty for both theRequestandResponseWeb APIs inboa_runtime, addressing issue #4992. Previously, cloning a request or response would fail because it wasn't implemented, and body consuming methods weren't properly ensuring that a given buffer is only drained once per spec.Changes Made
body_used: Cell<bool>internal state wrapped in#[unsafe_ignore_trace]inside bothJsRequestandJsResponse.#[boa(getter)]forbodyUsedreturning a boolean forRequestandResponse.clone()via standard standard JS method binding (clone_jsinternally mapped toclone), appropriately deep cloning fields (likeHeaders) while sharing the internal Request/Response structure safely.pub fn deep_clone(&self) -> Selfstandard toJsHeadersinsideheaders.rsin order to ensure the newly clonedRequest/Responsehas its own distinct map of headers.bytes(),text(), andjson()withinJsResponseto fail eagerly with aTypeErrorifbodyUsedis currentlytrue. Otherwise, it trips the internal flag and resolves the promise properly.Testing
cargo clippy -p boa_runtime --all-featureswith zero warnings.cargo test -p boa_runtimeresolving all internal checks.JsNativeError.